fix: listing SSE encrypted multipart objects #18786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GetActualSize() was heavily relying on o.Parts() to be non-empty to figure out if the object is multipart or not, however we have many indicators of if an object is multipart or not. Blindly assuming that o.Parts == nil is not a multipart is an incorrect expectation, instead multipart must be obtained via - Stored metadata value incating this is multipart encrypted object. - Rely on <meta>-actual-size metadata to get the real size of the object, this value is preserved for additional reasons such as these. - ETag != 32 length
harshavardhana
force-pushed
the
fix-sse-kms
branch
from
ce0268d
to
7c6bde1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Contribution License
All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request, I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.
Description
fix: listing SSE encrypted multipart objects
Motivation and Context
GetActualSize() was heavily relying on o.Parts()
to be non-empty to figure out if the object is multipart or not,
However, we have many indicators of whether an object is multipart
or not.
Blindly assuming that o.Parts == nil is not a multipart, is an
incorrect expectation instead, multipart must be obtained via
Stored metadata value indicating this is a multipart encrypted object.
Rely on -actual-size metadata to get the object's actual size.
This value is preserved for additional reasons such as these.
ETag != 32 length
How to test this PR?
Adding CI/CD tests
Types of changes
Checklist:
commit-idorPR #here)