Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use +Inf label additionally for Histogram metrics #18807

Merged
merged 4 commits into from
Jan 18, 2024

Conversation

shtripat
Copy link
Contributor

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

Motivation and Context

Issue: #18790

How to test this PR?

mc admin prometheus metrics ALIAS | grep ttfb would show additional rows with label +Inf as below

# HELP minio_s3_requests_ttfb_seconds_distribution Distribution of time to first byte across API calls
# TYPE minio_s3_requests_ttfb_seconds_distribution gauge
minio_s3_requests_ttfb_seconds_distribution{api="getbucketlocation",le="+Inf",server="127.0.0.1:9000"} 1
minio_s3_requests_ttfb_seconds_distribution{api="getbucketlocation",le="0.050",server="127.0.0.1:9000"} 1
minio_s3_requests_ttfb_seconds_distribution{api="getbucketlocation",le="0.100",server="127.0.0.1:9000"} 1
minio_s3_requests_ttfb_seconds_distribution{api="getbucketlocation",le="0.250",server="127.0.0.1:9000"} 1
minio_s3_requests_ttfb_seconds_distribution{api="getbucketlocation",le="0.500",server="127.0.0.1:9000"} 1
minio_s3_requests_ttfb_seconds_distribution{api="getbucketlocation",le="1.000",server="127.0.0.1:9000"} 1
minio_s3_requests_ttfb_seconds_distribution{api="getbucketlocation",le="10.000",server="127.0.0.1:9000"} 1
minio_s3_requests_ttfb_seconds_distribution{api="getbucketlocation",le="2.500",server="127.0.0.1:9000"} 1
minio_s3_requests_ttfb_seconds_distribution{api="getbucketlocation",le="5.000",server="127.0.0.1:9000"} 1
minio_s3_requests_ttfb_seconds_distribution{api="getbucketobjectlockconfiguration",le="+Inf",server="127.0.0.1:9000"} 1
minio_s3_requests_ttfb_seconds_distribution{api="getbucketobjectlockconfiguration",le="0.050",server="127.0.0.1:9000"} 1
minio_s3_requests_ttfb_seconds_distribution{api="getbucketobjectlockconfiguration",le="0.100",server="127.0.0.1:9000"} 1
minio_s3_requests_ttfb_seconds_distribution{api="getbucketobjectlockconfiguration",le="0.250",server="127.0.0.1:9000"} 1
minio_s3_requests_ttfb_seconds_distribution{api="getbucketobjectlockconfiguration",le="0.500",server="127.0.0.1:9000"} 1
minio_s3_requests_ttfb_seconds_distribution{api="getbucketobjectlockconfiguration",le="1.000",server="127.0.0.1:9000"} 1
minio_s3_requests_ttfb_seconds_distribution{api="getbucketobjectlockconfiguration",le="10.000",server="127.0.0.1:9000"} 1
minio_s3_requests_ttfb_seconds_distribution{api="getbucketobjectlockconfiguration",le="2.500",server="127.0.0.1:9000"} 1
minio_s3_requests_ttfb_seconds_distribution{api="getbucketobjectlockconfiguration",le="5.000",server="127.0.0.1:9000"} 1
minio_s3_requests_ttfb_seconds_distribution{api="headbucket",le="+Inf",server="127.0.0.1:9000"} 1
minio_s3_requests_ttfb_seconds_distribution{api="headbucket",le="0.050",server="127.0.0.1:9000"} 1
minio_s3_requests_ttfb_seconds_distribution{api="headbucket",le="0.100",server="127.0.0.1:9000"} 1
minio_s3_requests_ttfb_seconds_distribution{api="headbucket",le="0.250",server="127.0.0.1:9000"} 1
minio_s3_requests_ttfb_seconds_distribution{api="headbucket",le="0.500",server="127.0.0.1:9000"} 1
minio_s3_requests_ttfb_seconds_distribution{api="headbucket",le="1.000",server="127.0.0.1:9000"} 1
minio_s3_requests_ttfb_seconds_distribution{api="headbucket",le="10.000",server="127.0.0.1:9000"} 1
minio_s3_requests_ttfb_seconds_distribution{api="headbucket",le="2.500",server="127.0.0.1:9000"} 1
minio_s3_requests_ttfb_seconds_distribution{api="headbucket",le="5.000",server="127.0.0.1:9000"} 1
minio_s3_requests_ttfb_seconds_distribution{api="newmultipartupload",le="+Inf",server="127.0.0.1:9000"} 1
minio_s3_requests_ttfb_seconds_distribution{api="newmultipartupload",le="0.050",server="127.0.0.1:9000"} 1
minio_s3_requests_ttfb_seconds_distribution{api="newmultipartupload",le="0.100",server="127.0.0.1:9000"} 1
minio_s3_requests_ttfb_seconds_distribution{api="newmultipartupload",le="0.250",server="127.0.0.1:9000"} 1
minio_s3_requests_ttfb_seconds_distribution{api="newmultipartupload",le="0.500",server="127.0.0.1:9000"} 1
minio_s3_requests_ttfb_seconds_distribution{api="newmultipartupload",le="1.000",server="127.0.0.1:9000"} 1
minio_s3_requests_ttfb_seconds_distribution{api="newmultipartupload",le="10.000",server="127.0.0.1:9000"} 1
minio_s3_requests_ttfb_seconds_distribution{api="newmultipartupload",le="2.500",server="127.0.0.1:9000"} 1
minio_s3_requests_ttfb_seconds_distribution{api="newmultipartupload",le="5.000",server="127.0.0.1:9000"} 1
minio_s3_requests_ttfb_seconds_distribution{api="putobjectpart",le="+Inf",server="127.0.0.1:9000"} 306
minio_s3_requests_ttfb_seconds_distribution{api="putobjectpart",le="0.050",server="127.0.0.1:9000"} 306
minio_s3_requests_ttfb_seconds_distribution{api="putobjectpart",le="0.100",server="127.0.0.1:9000"} 306
minio_s3_requests_ttfb_seconds_distribution{api="putobjectpart",le="0.250",server="127.0.0.1:9000"} 306
minio_s3_requests_ttfb_seconds_distribution{api="putobjectpart",le="0.500",server="127.0.0.1:9000"} 306
minio_s3_requests_ttfb_seconds_distribution{api="putobjectpart",le="1.000",server="127.0.0.1:9000"} 306
minio_s3_requests_ttfb_seconds_distribution{api="putobjectpart",le="10.000",server="127.0.0.1:9000"} 306
minio_s3_requests_ttfb_seconds_distribution{api="putobjectpart",le="2.500",server="127.0.0.1:9000"} 306
minio_s3_requests_ttfb_seconds_distribution{api="putobjectpart",le="5.000",server="127.0.0.1:9000"} 306

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

cmd/metrics-v2.go Outdated Show resolved Hide resolved
Signed-off-by: Shubhendu Ram Tripathi <shubhendu@minio.io>
Signed-off-by: Shubhendu Ram Tripathi <shubhendu@minio.io>
Signed-off-by: Shubhendu Ram Tripathi <shubhendu@minio.io>
Signed-off-by: Shubhendu Ram Tripathi <shubhendu@minio.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants