Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

capture I/O in waiting and total tokens in diskMetrics #18819

Merged
merged 2 commits into from
Jan 18, 2024

Conversation

harshavardhana
Copy link
Member

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

capture I/O in waiting and total tokens in diskMetrics

Motivation and Context

This is needed for the subsequent changes
in ServerUpdate(), ServerRestart() etc.

How to test this PR?

This change mainly captures additional
metrics, for blocked I/O to be responded
back via DiskInfo() call for top layer
callers to perform certain maintenance
activity.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

This is needed for the subsequent changes
in ServerUpdate(), ServerRestart() etc.
cmd/storage-rest-common.go Show resolved Hide resolved
cmd/xl-storage-disk-id-check.go Show resolved Hide resolved
cmd/xl-storage-disk-id-check.go Show resolved Hide resolved
@harshavardhana
Copy link
Member Author

I realize that there are no changes in the code, I have replied to your comments @klauspost please let me know if you want me to rework anything.

@harshavardhana harshavardhana requested review from klauspost and kannappanr and removed request for klauspost January 18, 2024 17:26
@harshavardhana harshavardhana merged commit 7c06732 into minio:master Jan 18, 2024
20 checks passed
@harshavardhana harshavardhana deleted the capture-disk-hung branch January 18, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants