improve server update behavior by re-using memory properly #18831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this on purpose include #18826 ? |
Yes basically trying to get this in right after that. |
harshavardhana
force-pushed
the
fix-update
branch
from
87f235f
to
ff56efd
Compare
harshavardhana
added
performance/optimize
next-release
harshavardhana
requested review from
fwessels,
cniackz,
vadmeste,
krisis and
poornas
krisis
approved these changes
Jan 19, 2024
harshavardhana
force-pushed
the
fix-update
branch
from
ff56efd
to
71420e9
Compare
poornas
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Contribution License
All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.
Description
improve server update behavior by re-using memory properly
Motivation and Context
fixes, slow binary update behavior by reusing memory
and avoiding gob for megabyte streams.
How to test this PR?
This PR needs #18826 to be merged first
Types of changes
Checklist:
commit-idorPR #here)