-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compress binary while sending it to all the nodes #18837
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
force-pushed
the
compress-update
branch
2 times, most recently
from
January 21, 2024 12:44
c16c614
to
9acb5b6
Compare
harshavardhana
force-pushed
the
compress-update
branch
from
January 21, 2024 12:48
9acb5b6
to
e020663
Compare
harshavardhana
force-pushed
the
compress-update
branch
from
January 21, 2024 13:06
e020663
to
89bce60
Compare
harshavardhana
added
new-feature
next-release
scheduled for upcoming release
needs-review
labels
Jan 21, 2024
klauspost
reviewed
Jan 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a big difference (~2MB), but we might as well take it.
(imports should be changed ofc)
Also limit the amount of concurrency when sending binary updates to peers, avoid high network over TX that can cause disconnection events for the node sending updates.
harshavardhana
force-pushed
the
compress-update
branch
from
January 22, 2024 19:16
89bce60
to
8040eab
Compare
done @klauspost |
pjuarezd
approved these changes
Jan 22, 2024
kannappanr
approved these changes
Jan 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Contribution License
All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.
Description
compress binary while sending it to all the nodes
Motivation and Context
Also, limit the amount of concurrency when sending
binary updates to peers, avoid high network over
TX that can cause disconnection events for the
node sending updates.
How to test this PR?
Just build minio with a RELEASE date that is older than
the current RELEASE date, you get to use the
mc admin update alias/
command.
Types of changes
Checklist:
commit-id
orPR #
here)