Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compress binary while sending it to all the nodes #18837

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

harshavardhana
Copy link
Member

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

compress binary while sending it to all the nodes

Motivation and Context

Also, limit the amount of concurrency when sending
binary updates to peers, avoid high network over
TX that can cause disconnection events for the
node sending updates.

How to test this PR?

Just build minio with a RELEASE date that is older than
the current RELEASE date, you get to use the mc admin update alias/
command.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

Copy link
Contributor

@klauspost klauspost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a big difference (~2MB), but we might as well take it.

(imports should be changed ofc)

cmd/update.go Outdated Show resolved Hide resolved
cmd/peer-rest-server.go Outdated Show resolved Hide resolved
cmd/update.go Outdated Show resolved Hide resolved
Also limit the amount of concurrency when sending
binary updates to peers, avoid high network over
TX that can cause disconnection events for the
node sending updates.
@harshavardhana
Copy link
Member Author

done @klauspost

Copy link
Contributor

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@harshavardhana harshavardhana merged commit 961f7de into minio:master Jan 22, 2024
20 checks passed
@harshavardhana harshavardhana deleted the compress-update branch January 22, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-review new-feature next-release scheduled for upcoming release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants