Distribution bucket metrics with site replication #18841
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Contribution License
All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.
Description
If site replication is enabled, we should still show the size and version distribution histogram metrics at bucket level.
Motivation and Context
Issue: #18838
How to test this PR?
Create two minio sites and setup site replication between them.
Add couple of bucket to first site and and load multiple objects with different sizes and also load multiple versions of the objects.
Now execute
mc admin prometheus metrics ALIAS-SITE-1 bucket | grep _size_distribution
andmc admin prometheus metrics ALIAS-SITE-1 bucket | grep _version_distribution
and you should see metrics as belowTypes of changes
Checklist:
commit-id
orPR #
here)