Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distribution bucket metrics with site replication #18841

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

shtripat
Copy link
Contributor

@shtripat shtripat commented Jan 22, 2024

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

If site replication is enabled, we should still show the size and version distribution histogram metrics at bucket level.

Motivation and Context

Issue: #18838

How to test this PR?

Create two minio sites and setup site replication between them.
Add couple of bucket to first site and and load multiple objects with different sizes and also load multiple versions of the objects.
Now execute mc admin prometheus metrics ALIAS-SITE-1 bucket | grep _size_distribution and mc admin prometheus metrics ALIAS-SITE-1 bucket | grep _version_distribution and you should see metrics as below

# HELP minio_bucket_objects_size_distribution Distribution of object sizes in the bucket, includes label for the bucket name
# TYPE minio_bucket_objects_size_distribution gauge
minio_bucket_objects_size_distribution{bucket="test-bucket",range="BETWEEN_1024B_AND_1_MB",server="127.0.0.1:9000"} 0
minio_bucket_objects_size_distribution{bucket="test-bucket",range="BETWEEN_1024_B_AND_64_KB",server="127.0.0.1:9000"} 0
minio_bucket_objects_size_distribution{bucket="test-bucket",range="BETWEEN_10_MB_AND_64_MB",server="127.0.0.1:9000"} 20
minio_bucket_objects_size_distribution{bucket="test-bucket",range="BETWEEN_128_MB_AND_512_MB",server="127.0.0.1:9000"} 0
minio_bucket_objects_size_distribution{bucket="test-bucket",range="BETWEEN_1_MB_AND_10_MB",server="127.0.0.1:9000"} 10
minio_bucket_objects_size_distribution{bucket="test-bucket",range="BETWEEN_256_KB_AND_512_KB",server="127.0.0.1:9000"} 0
minio_bucket_objects_size_distribution{bucket="test-bucket",range="BETWEEN_512_KB_AND_1_MB",server="127.0.0.1:9000"} 0
minio_bucket_objects_size_distribution{bucket="test-bucket",range="BETWEEN_64_KB_AND_256_KB",server="127.0.0.1:9000"} 0
minio_bucket_objects_size_distribution{bucket="test-bucket",range="BETWEEN_64_MB_AND_128_MB",server="127.0.0.1:9000"} 10
minio_bucket_objects_size_distribution{bucket="test-bucket",range="GREATER_THAN_512_MB",server="127.0.0.1:9000"} 10
minio_bucket_objects_size_distribution{bucket="test-bucket",range="LESS_THAN_1024_B",server="127.0.0.1:9000"} 0
minio_bucket_objects_size_distribution{bucket="test-bucket-ver",range="BETWEEN_1024B_AND_1_MB",server="127.0.0.1:9000"} 0
minio_bucket_objects_size_distribution{bucket="test-bucket-ver",range="BETWEEN_1024_B_AND_64_KB",server="127.0.0.1:9000"} 0
minio_bucket_objects_size_distribution{bucket="test-bucket-ver",range="BETWEEN_10_MB_AND_64_MB",server="127.0.0.1:9000"} 20
minio_bucket_objects_size_distribution{bucket="test-bucket-ver",range="BETWEEN_128_MB_AND_512_MB",server="127.0.0.1:9000"} 0
minio_bucket_objects_size_distribution{bucket="test-bucket-ver",range="BETWEEN_1_MB_AND_10_MB",server="127.0.0.1:9000"} 0
minio_bucket_objects_size_distribution{bucket="test-bucket-ver",range="BETWEEN_256_KB_AND_512_KB",server="127.0.0.1:9000"} 0
minio_bucket_objects_size_distribution{bucket="test-bucket-ver",range="BETWEEN_512_KB_AND_1_MB",server="127.0.0.1:9000"} 0
minio_bucket_objects_size_distribution{bucket="test-bucket-ver",range="BETWEEN_64_KB_AND_256_KB",server="127.0.0.1:9000"} 0
minio_bucket_objects_size_distribution{bucket="test-bucket-ver",range="BETWEEN_64_MB_AND_128_MB",server="127.0.0.1:9000"} 20
minio_bucket_objects_size_distribution{bucket="test-bucket-ver",range="GREATER_THAN_512_MB",server="127.0.0.1:9000"} 10
minio_bucket_objects_size_distribution{bucket="test-bucket-ver",range="LESS_THAN_1024_B",server="127.0.0.1:9000"} 0
# HELP minio_bucket_objects_version_distribution Distribution of object sizes in the bucket, includes label for the bucket name
# TYPE minio_bucket_objects_version_distribution gauge
minio_bucket_objects_version_distribution{bucket="test-bucket",range="BETWEEN_1000_AND_10000",server="127.0.0.1:9000"} 0
minio_bucket_objects_version_distribution{bucket="test-bucket",range="BETWEEN_100_AND_1000",server="127.0.0.1:9000"} 0
minio_bucket_objects_version_distribution{bucket="test-bucket",range="BETWEEN_10_AND_100",server="127.0.0.1:9000"} 0
minio_bucket_objects_version_distribution{bucket="test-bucket",range="BETWEEN_2_AND_10",server="127.0.0.1:9000"} 0
minio_bucket_objects_version_distribution{bucket="test-bucket",range="GREATER_THAN_10000",server="127.0.0.1:9000"} 0
minio_bucket_objects_version_distribution{bucket="test-bucket",range="SINGLE_VERSION",server="127.0.0.1:9000"} 50
minio_bucket_objects_version_distribution{bucket="test-bucket",range="UNVERSIONED",server="127.0.0.1:9000"} 0
minio_bucket_objects_version_distribution{bucket="test-bucket-ver",range="BETWEEN_1000_AND_10000",server="127.0.0.1:9000"} 0
minio_bucket_objects_version_distribution{bucket="test-bucket-ver",range="BETWEEN_100_AND_1000",server="127.0.0.1:9000"} 0
minio_bucket_objects_version_distribution{bucket="test-bucket-ver",range="BETWEEN_10_AND_100",server="127.0.0.1:9000"} 20
minio_bucket_objects_version_distribution{bucket="test-bucket-ver",range="BETWEEN_2_AND_10",server="127.0.0.1:9000"} 0
minio_bucket_objects_version_distribution{bucket="test-bucket-ver",range="GREATER_THAN_10000",server="127.0.0.1:9000"} 0
minio_bucket_objects_version_distribution{bucket="test-bucket-ver",range="SINGLE_VERSION",server="127.0.0.1:9000"} 30
minio_bucket_objects_version_distribution{bucket="test-bucket-ver",range="UNVERSIONED",server="127.0.0.1:9000"} 0

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

If site replication is enabled, we should still show the size and
version distribution histogram metrics at bucket level.

Signed-off-by: Shubhendu Ram Tripathi <shubhendu@minio.io>
Copy link
Contributor

@klauspost klauspost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshavardhana harshavardhana merged commit 65c4d55 into minio:master Jan 22, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants