Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid reload of 'format.json' over the network under normal conditions #18842

Merged
merged 2 commits into from
Jan 23, 2024

Conversation

harshavardhana
Copy link
Member

@harshavardhana harshavardhana commented Jan 22, 2024

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

avoid reloading of 'format.json' over the network under normal conditions

Motivation and Context

reloading of format.json is not necessary until a local
disconnect event for the disk, so we should keep this is
cached for all future calls.

How to test this PR?

Nothing special CI/CD should cover the scenarios; other
testing requires manual are disk replacement etc.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

@harshavardhana
Copy link
Member Author

This PR changes the restart times from 324 nodes with 24 disks each i.e 7776 disks from 2min to 1min

Restarted `local` successfully in 2 minutes

to

Restarted `local` successfully in 1 minutes

Copy link
Contributor

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshavardhana harshavardhana merged commit 52229a2 into minio:master Jan 23, 2024
20 checks passed
@harshavardhana harshavardhana deleted the load-format branch January 23, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants