Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate bootstrap logic directly to websockets #18855

Merged
merged 1 commit into from
Jan 24, 2024
Merged

migrate bootstrap logic directly to websockets #18855

merged 1 commit into from
Jan 24, 2024

Conversation

harshavardhana
Copy link
Member

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

migrate bootstrap logic directly to websockets

Motivation and Context

improve performance for startup sequences by
2x for 300+ nodes.

How to test this PR?

You would need a large setup such as 324 nodes and 24 drives each.

Restarted `local` successfully in 39 seconds

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

@harshavardhana harshavardhana added priority: high next-release scheduled for upcoming release labels Jan 23, 2024
@harshavardhana harshavardhana force-pushed the bootstrap-speedup branch 4 times, most recently from e7ce0dd to 63b626a Compare January 24, 2024 07:19
klauspost
klauspost requested changes Jan 24, 2024
View reviewed changes
cmd/bootstrap-peer-server.go Show resolved Hide resolved
cmd/bootstrap-peer-server.go Show resolved Hide resolved
cmd/bootstrap-peer-server.go Outdated Show resolved Hide resolved
cmd/bootstrap-peer-server.go Show resolved Hide resolved
cmd/bootstrap-peer-server.go Show resolved Hide resolved
@harshavardhana
Copy link
Member Author

everything is addressed @klauspost PTAL

fwessels
fwessels reviewed Jan 24, 2024
View reviewed changes
Makefile Show resolved Hide resolved
poornas
poornas reviewed Jan 24, 2024
View reviewed changes
cmd/storage-errors.go Outdated Show resolved Hide resolved
fwessels
fwessels reviewed Jan 24, 2024
View reviewed changes
cmd/storage-errors.go Outdated Show resolved Hide resolved
@harshavardhana
migrate bootstrap logic directly to websockets
ed1119f 
improve performance for startup sequences by
2x for 300+ nodes.
fwessels
fwessels reviewed Jan 24, 2024
View reviewed changes
Copy link
Contributor

@fwessels fwessels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, otherwise looks good.

@harshavardhana harshavardhana merged commit e377bb9 into minio:master Jan 24, 2024
20 checks passed
@harshavardhana harshavardhana deleted the bootstrap-speedup branch January 24, 2024 21:36
@harshavardhana harshavardhana mentioned this pull request Jan 25, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poornas poornas poornas approved these changes

@fwessels fwessels fwessels approved these changes

@vadmeste vadmeste Awaiting requested review from vadmeste

@krisis krisis Awaiting requested review from krisis

@kannappanr kannappanr Awaiting requested review from kannappanr

@klauspost klauspost Awaiting requested review from klauspost

Assignees
No one assigned
Labels
needs-review next-release scheduled for upcoming release priority: high
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@harshavardhana @poornas @fwessels @klauspost @bh4t