Fix all racy use of NewDeadlineWorker #18861
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pretty much all use of
NewDeadlineWorker
which relied on secondary values were used in a racy fashion, which could lead to inconsistent errors/data being returned.Rewrite all of these to use a generic
WithDeadline[V any]
caller which can return an error alongside a value. Also propagates the deadline downstream.Remove the stateful aspect (error preservation) of DeadlineWorker - it was racy if used - but it wasn't AFAICT.
Fixes races like:
Probably all the way back from #17701
How to test this PR?
CI will cover. Run with
-race
to reproTypes of changes
Checklist: