Add separate grid reconnection mutex #18862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Give more safety around reconnects and make sure a state change isn't missed. Tested with several runs of `λ go test -race -v -count=500` Adds separate mutex and doesn't mix in the testing mutex.
harshavardhana
requested review from
poornas,
fwessels,
piotr-topnotch and
zveinn
harshavardhana
approved these changes
Jan 24, 2024
poornas
approved these changes
Jan 24, 2024
fwessels
reviewed
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Give more safety around reconnects and make sure a state change isn't missed. In principle several incoming requests could be processed at the same time under strange network conditions.
Adds separate mutex and doesn't mix in the testing mutex.
How to test this PR?
Tested with several runs of
λ go test -race -v -count=500which includes reconnection test.Types of changes