Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow bucket import to be idempotent #18873

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Conversation

harshavardhana
Copy link
Member

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request, I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

allow bucket import to be idempotent

Motivation and Context

do not need to be defensive in our approach,
we should override anything and everything
in the import process, do not care about what
currently exists on the disk - backup is the
source of truth.

How to test this PR?

Create an inconsistent state() on .metadata.bin and
Then, we try to restore, but we miserably fail.

We must not fail at any cost, unless of course we couldn't
save the damn file.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

do not need to be defensive in our approach,
we should simply override anything everything
in import process, do not care about what
currently exists on the disk - backup is the
source of truth.
@harshavardhana harshavardhana merged commit f449a7a into minio:master Jan 26, 2024
20 checks passed
@harshavardhana harshavardhana deleted the force branch January 26, 2024 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants