remove local disk metrics from cluster metrics #18886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
added
do-not-close
needs-docs
harshavardhana
force-pushed
the
optimize-metrics
branch
from
218419f
to
88689c7
Compare
harshavardhana
force-pushed
the
optimize-metrics
branch
from
88689c7
to
2e92e4e
Compare
klauspost
approved these changes
Jan 28, 2024
harshavardhana
force-pushed
the
optimize-metrics
branch
from
2e92e4e
to
147e32c
Compare
local disk metrics were polluting cluster metrics Please remove them instead of adding relevant ones. - batch job metrics were incorrectly kept at bucket metrics endpoint, move it to cluster metrics. - add tier metrics to cluster peer metrics from the node. - fix missing set level cluster health metrics
harshavardhana
force-pushed
the
optimize-metrics
branch
from
147e32c
to
37bcc38
Compare
harshavardhana
force-pushed
the
optimize-metrics
branch
from
37bcc38
to
ca6085e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Contribution License
All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request, I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.
Description
remove local disk metrics from cluster metrics
Motivation and Context
local disk metrics were polluting cluster metrics
Please remove them instead of adding relevant ones.
batch job metrics were incorrectly visible on the bucket
metrics endpoint, move it to cluster metrics.
add tier metrics to cluster peer metrics from the node.
How to test this PR?
It needs to be verified kind of manually via
curl http://localhost:9000/minio/v2/metrics/clusterTypes of changes
Checklist:
commit-idorPR #here)