enable xattr capture by default #18911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
force-pushed
the
fix-drive-quorum
branch
from
2b69aa2
to
5a1b2e8
Compare
- healing must not set the write xattr because that is the job of active healing to update. what we need to preserve is permanent deletes. - remove older env for drive monitoring and enable it accordingly, as a global value.
harshavardhana
force-pushed
the
fix-drive-quorum
branch
from
5a1b2e8
to
914a42b
Compare
jiuker
requested changes
Jan 30, 2024
|
I hope this will be merged soon, because I need the ability to turn of the disk monitoring |
poornas
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Contribution License
All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.
Description
enable xattr capture by default
Motivation and Context
healing must not set the write xattr because that is the
job of active healing to update. What we need to preserve
is permanent deletes.
remove older env for drive monitoring and enable it
accordingly as a global value.
How to test this PR?
CI/CD should cover it.
Types of changes
Checklist:
commit-idorPR #here)