fix: permission checks for editing access keys #18928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
requested changes
Jan 31, 2024
donatello
force-pushed
the
fix-acckey-edit
branch
2 times, most recently
from
430f698
to
766b7e8
Compare
|
Tests updated |
klauspost
reviewed
Jan 31, 2024
donatello
force-pushed
the
fix-acckey-edit
branch
from
766b7e8
to
3aa80dc
Compare
harshavardhana
approved these changes
Jan 31, 2024
vadmeste
reviewed
Jan 31, 2024
donatello
force-pushed
the
fix-acckey-edit
branch
from
3aa80dc
to
85cd632
Compare
With this change, only a user with `UpdateServiceAccountAdminAction` permission is able to edit access keys. We would like to let a user edit their own access keys, however the feature needs to be re-designed for better security and integration with external systems like AD/LDAP and OpenID. This change prevents privilege escalation via service accounts.
donatello
force-pushed
the
fix-acckey-edit
branch
from
85cd632
to
9882b33
Compare
8 tasks
2 tasks
Adphi
pushed a commit
to linka-cloud/minio-gateway
that referenced
this pull request
Mar 21, 2024
With this change, only a user with `UpdateServiceAccountAdminAction` permission is able to edit access keys. We would like to let a user edit their own access keys, however the feature needs to be re-designed for better security and integration with external systems like AD/LDAP and OpenID. This change prevents privilege escalation via service accounts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With this change, only a user with
UpdateServiceAccountAdminActionpermission is able to edit access keys.We would like to let a user edit their own access keys, however the feature needs to be re-designed for better security and integration with external systems like AD/LDAP and OpenID.
This change prevents privilege escalation via service accounts.
Motivation and Context
How to test this PR?
Types of changes
Checklist:
commit-idorPR #here)