move a collection of peer APIs to websockets #18936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
requested review from
klauspost,
vadmeste,
zveinn and
fwessels
harshavardhana
changed the title
harshavardhana
commented
Feb 1, 2024
harshavardhana
force-pushed
the
bucket-checks
branch
from
401693d
to
cf91286
Compare
zveinn
approved these changes
Feb 1, 2024
harshavardhana
force-pushed
the
bucket-checks
branch
from
cf91286
to
fdf2e90
Compare
vadmeste
approved these changes
Feb 1, 2024
fwessels
reviewed
Feb 1, 2024
fwessels
reviewed
Feb 1, 2024
fwessels
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Contribution License
All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.
Description
move a collection of peer APIs to WebSockets
Motivation and Context
many of these APIs do not send any
data to peer, neither receive. These
APIs don't need to be done over a HTTP
connection at all.
How to test this PR?
This change mainly provides scalable
use of these features for large clusters.
Types of changes
Checklist:
commit-idorPR #here)