Fix mux client memory leak #18956
Merged
Fix mux client memory leak #18956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing client cancellation, resulting in memory buildup tracing back to context.WithCancelCause/context.WithCancelDeadlineCause
harshavardhana
approved these changes
Feb 2, 2024
klauspost
added a commit
to klauspost/minio
that referenced
this pull request
Feb 6, 2024
Subrouted requests were also leaking contexts in mux clients. Similar to minio#18956
1 task
harshavardhana
pushed a commit
that referenced
this pull request
Feb 6, 2024
Subrouted requests were also leaking contexts in mux clients. Similar to #18956
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add missing client cancellation, resulting in memory buildup tracing back to
context.WithCancelCauseandcontext.WithCancelDeadlineCause.How to test this PR?
Test buildup on active cluster. Check pprof.
Types of changes