Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIx unexpected behavior when creating service account #19036

Merged
merged 6 commits into from Feb 13, 2024

Conversation

taran-p
Copy link
Contributor

@taran-p taran-p commented Feb 12, 2024

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

Fixes bahvior so creating service account will error if secret key is provided without access key.
Fixes #19003

Motivation and Context

Explained in #19003

How to test this PR?

Attempt to create a service account (access key) using Console with a blank access key but specified secret key.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

cmd/iam.go Show resolved Hide resolved
cmd/api-errors.go Outdated Show resolved Hide resolved
Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshavardhana harshavardhana merged commit 4d94609 into minio:master Feb 13, 2024
20 checks passed
@taran-p taran-p deleted the fix-service-account branch February 13, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Likely unintentional behaviour adding service account through API
4 participants