Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update API label names for metrics #19162

Merged
merged 1 commit into from Mar 1, 2024
Merged

Conversation

donatello
Copy link
Member

Description

This change makes the label names consistent with the handler names. This is in preparation to use reflection based API handler function names for the api labels so they will be the same as tracing, auditing and logging names for these API calls.

Motivation and Context

Improve observability.

How to test this PR?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

This change makes the label names consistent with the handler names.
This is in preparation to use reflection based API handler function
names for the api labels so they will be the same as tracing, auditing
and logging names for these API calls.
@donatello donatello merged commit 6769d4d into minio:master Mar 1, 2024
20 checks passed
@donatello donatello deleted the metric-labels branch March 1, 2024 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants