merge startHTTPLogger() many callers into a simpler pattern #19211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiuker
approved these changes
Mar 6, 2024
fixes couple of bugs like - ping(ctx) was creating a logger without updating number of workers leading to incorrect nWorkers scaling, causing an additional worker that is not tracked properly. - h.logCh <- entry could potentially hang for when the queue is full on heavily loaded systems.
harshavardhana
force-pushed
the
fix-workers
branch
from
df497fe
to
e4ce067
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Contribution License
All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.
Description
merge startHTTPLogger() many callers into a simpler pattern
Motivation and Context
fixes a couple of bugs like
ping(ctx) was creating a logger without updating the number
of workers leading to incorrect nWorkers scaling, causing
an additional worker that is not tracked properly.
h.logCh <- entry could potentially hang for when the queue
is full, on heavily loaded systems.
How to test this PR?
Seen issues in a customer environment. For
logCh <- entryand an additional worker scaling seen when it must be only 16 workers, causing more traffic to the webhook endpoint.Types of changes
Checklist:
commit-idorPR #here)