Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow retaining parity SLA to be configurable #19260

Merged
merged 1 commit into from Mar 14, 2024

Conversation

harshavardhana
Copy link
Member

@harshavardhana harshavardhana commented Mar 14, 2024

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request, I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

feat: allow retaining parity SLA to be configurable

Motivation and Context

At scale, customers might start with failed drives, causing
skew in the overall usage ratio per EC set.

Make this configurable so customers can turn it off as
needed depending on how comfortable they are with the
SLA.

How to test this PR?

To turn off retaining parity SLA and optimize for capacity
for objects when drives have failed, do this only when you
know what you are doing and usable space is more important
to you than additional parity for objects.

mc admin config set alias/ storage_class optimize=capacity

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

Copy link
Contributor

@klauspost klauspost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cmd/erasure-multipart.go Outdated Show resolved Hide resolved
at scale customers might start with failed drives,
causing skew in the overall usage ratio per EC set.

make this configurable such that customers can turn
this off as needed depending on how comfortable they
are.
@harshavardhana harshavardhana merged commit ce1c640 into minio:master Mar 14, 2024
20 checks passed
@harshavardhana harshavardhana deleted the fix-ec branch March 14, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants