write anything beyond 4k to be written in 4k pages #19269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klauspost
reviewed
Mar 15, 2024
harshavardhana
force-pushed
the
write-unaligned
branch
from
cbcbfab
to
63b6ddf
Compare
klauspost
approved these changes
Mar 15, 2024
harshavardhana
force-pushed
the
write-unaligned
branch
2 times, most recently
from
e941d06
to
7330376
Compare
we were prematurely not writing 4k pages while we could have due to the fact that most buffers would be multiples of 4k upto some number and there shall be some remainder. We only need to write the remainder without O_DIRECT.
harshavardhana
force-pushed
the
write-unaligned
branch
from
7330376
to
9511d67
Compare
poornas
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Contribution License
All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.
Description
write anything beyond 4k to be written in 4k pages
Motivation and Context
we were prematurely not writing 4k pages while we
could have because most buffers would be multiples
of 4k up to some number, and there shall be some
remainder.
We only need to write the remainder without O_DIRECT
not the entire buffer.
How to test this PR?
CI/CD must test everything end-to-end
Types of changes
Checklist:
commit-idorPR #here)