Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add a default requests deadline when deadline is 0 #19287

Merged
merged 1 commit into from Mar 18, 2024

Conversation

harshavardhana
Copy link
Member

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

fix: add a default requests deadline when a deadline is 0

Motivation and Context

just pick sane defaults when nothing is set properly

How to test this PR?

This is mostly a eyeballed change but I can clearly
see that this can happen.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

@harshavardhana harshavardhana merged commit 741de4c into minio:master Mar 18, 2024
20 checks passed
@harshavardhana harshavardhana deleted the use-default-non-zero branch March 18, 2024 19:30
@harshavardhana
Copy link
Member Author

harshavardhana commented Mar 18, 2024

@donatello we need to make a new release, with this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next-release scheduled for upcoming release priority: high
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants