decom: Fix failed status after a failed decommission #19300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When returning the status of a decommissioned pool, a pool with a zero time StartedTime will be considered as an active pool, which is unexpected. This commit will always ensure that canceled/failed/completed status of a pool is returned.
vadmeste
force-pushed
the
fix-decom-status
branch
from
210e736
to
497ea31
Compare
harshavardhana
approved these changes
Mar 20, 2024
harshavardhana
pushed a commit
that referenced
this pull request
Mar 20, 2024
When returning the status of a decommissioned pool, a pool with zero time StartedTime will be considered an active pool, which is unexpected. This commit will always ensure that a pool's canceled/failed/completed status is returned.
kanagarajkm
pushed a commit
that referenced
this pull request
Mar 30, 2024
When returning the status of a decommissioned pool, a pool with zero time StartedTime will be considered an active pool, which is unexpected. This commit will always ensure that a pool's canceled/failed/completed status is returned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Contribution License
All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.
Description
When returning the status of a decommissioned pool, a pool with a zero
time StartedTime will be considered as an active pool, which is
unexpected. This commit will always ensure that canceled/failed/completed
status of a pool is returned.
Motivation and Context
Fix a pool switch to Active status after a decommissioning being failed
How to test this PR?
Types of changes
Checklist:
commit-idorPR #here)