Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow configuring inline shard size value #19336

Merged

Conversation

harshavardhana
Copy link
Member

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

allow configuring inline shard size value

Motivation and Context

performance of inline v/s non-inline seems to be 2x
difference - allow configuring this in some
situations when a bigger stripe for 1MiB object size
would fall under the inline category.

How to test this PR?

We need to do performance numbers to see the difference
allow this to be configurable for now.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

@harshavardhana harshavardhana force-pushed the allow-configuring-inline branch 5 times, most recently from eea0a18 to bec86ac Compare March 25, 2024 23:46
@harshavardhana
Copy link
Member Author

The feature is now hidden and will not be available via mc admin config get/set - this is only useful for exceptional cases where we want to test these things.

Since the config and its ENV is unavailable there is no point adding _MINIO on it.

@harshavardhana
Copy link
Member Author

this does not need a doc @feorlen @djwfyi

krisis

This comment was marked as resolved.

@harshavardhana harshavardhana merged commit 0a56dbd into minio:master Mar 26, 2024
20 checks passed
@harshavardhana harshavardhana deleted the allow-configuring-inline branch March 26, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants