Reduce big message RPC allocations #19390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ppropriate buffers. Use `ODirectPoolSmall` buffers for inline data in PutObject. Add separate rpc call for inline data that will fetch a buffer for the inline data before unmarshal. Should replace minio#19386
|
Seems like a typo check test just went crazy ;) |
This comment was marked as resolved.
This comment was marked as resolved.
harshavardhana
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds 32 -> 96KB RPC buffers. When we know the size needed fetch the appropriate buffers.
Add separate rpc call for inline data that will fetch a buffer for the inline data before unmarshal.
Should replace #19386
Motivation and Context
Reduce allocations and slice resizing
How to test this PR?
Perform uploads with inline data sizes.
Types of changes