Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new API errors for LDAP #19415

Merged
merged 3 commits into from Apr 6, 2024
Merged

Conversation

taran-p
Copy link
Contributor

@taran-p taran-p commented Apr 5, 2024

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

Adds API errors:
If LDAP is not enabled with an LDAP command
If LDAP short username is expected but DN is given

Uses these in the code

Motivation and Context

Currently these known errors return as internal errors

How to test this PR?

mc idp ldap accesskey create with LDAP not enabled, with incorrect username, or with a DN
mc idp ldap policy attach/detach with LDAP not enabled

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taran-p taran-p requested a review from donatello April 5, 2024 15:23
cmd/api-errors.go Outdated Show resolved Hide resolved
cmd/api-errors.go Show resolved Hide resolved
cmd/admin-handlers-idp-ldap.go Outdated Show resolved Hide resolved
@donatello donatello merged commit 9d63bb1 into minio:master Apr 6, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants