Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get rid of large buffers #19549

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Conversation

harshavardhana
Copy link
Member

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

fix: get rid of large buffers

Motivation and Context

these lead to run-away usage of memory
beyond which the Go's GC can handle, we
have to re-visit this differently, remove
this is for now.

How to test this PR?

Needs a large busy cluster, the change is self explanatory.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

these lead to run-away usage of memory
beyond which the Go's GC can handle, we
have to re-visit this differently, remove
this for now.
@harshavardhana
Copy link
Member Author

Getting rid of these buffers @klauspost, as I saw that in a customer environment with huge PUTs, this can lead to severe GC pressure.

We have to revisit this later perhaps by re-using globalByteCapPool()

@harshavardhana harshavardhana merged commit 03767d2 into minio:master Apr 19, 2024
20 checks passed
@harshavardhana harshavardhana deleted the get-rid branch April 19, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants