Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support preserving renameData() on inlined content during overwrites #19609

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

harshavardhana
Copy link
Member

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request, I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

support preserving renameData() on inlined content during overwrites

Motivation and Context

extending #19548 to inlined-data as well.

How to test this PR?

minio server /tmp/xl{1...12} &
mc mb myminio/testbucket/
mc cp /etc/hosts myminio/testbucket/

chown -R root. /tmp/xl{1..5}

mc cp /etc/hosts myminio/testbucket/
chown -R harsha. /tmp/xl{1..5}

## this would fail with master
mc cat myminio/testbucket/hosts

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

@harshavardhana harshavardhana merged commit 1d03bea into minio:master Apr 25, 2024
20 checks passed
@harshavardhana harshavardhana deleted the support-preserving branch April 25, 2024 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants