fix: LDAP init. issue when LDAP server is down #19619
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
At server startup, LDAP configuration is validated against the LDAP server. If the LDAP server is down at that point, we need to cleanly disable LDAP configuration. Previously, LDAP would remain configured but error out in strange ways because initialization did not complete without errors.
Motivation and Context
This can be seen easily when we start minio + ldap server together in docker-compose for e.g. using https://github.com/minio/minio-iam-testing/blob/main/docker-compose.yml
Types of changes
Checklist:
commit-id
orPR #
here)