support 'mc support perf object' with root login disabled #19672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is expected that whoever is using the credentials which has the proper set of permissions must be able to run. `mc support perf object` While the root login is disabled.
harshavardhana
requested review from
vadmeste,
krisis,
klauspost,
poornas and
kannappanr
shtripat
approved these changes
May 6, 2024
There was a problem hiding this comment.
LGTM. Verified with below steps.
- Started a MinIO instancce
- Created a new user
mc admin user add myminio testuser tespasswd - Attached the policy to the user
mc admin policy attach myminio consoleAdmin --user testuser - Re-started MinIO with root user disabled
MINIO_API_ROOT_ACCESS=off ./minio server ./test-root/ --address :9010 - Created alias with new user
mc alias set myminio1 http://localhost:9010 testuser testpasswdand registered the cluster with subnet - Ran the command
mc support perf object myminio1to upload the perf report
poornas
approved these changes
May 6, 2024
prakashsvmx
approved these changes
May 6, 2024
There was a problem hiding this comment.
Verified with the below actions in a policy ( diagnostics policy with additional actions) . looks good to me.
"admin:ConfigUpdate",
"admin:ConsoleLog",
"admin:OBDInfo",
"admin:Prometheus",
"admin:BandwidthMonitor",
"admin:Profiling",
"admin:ServerInfo",
"admin:ServerTrace",
"admin:TopLocksInfo"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Contribution License
All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.
Description
support 'mc support perf object' with root login disabled
Motivation and Context
It is expected that whoever is using the credentials which has
the proper set of permissions must be able to run.
mc support perf objectWhile the root login is disabled.
How to test this PR?
Turn-off root login and run
mc support perf objecton a registered cluster with admin permissions.Types of changes
Checklist:
commit-idorPR #here)