Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ignore AWSAccessKeyId check for SignV2 policy condition #19673

Merged
merged 1 commit into from
May 6, 2024

Conversation

jiuker
Copy link
Contributor

@jiuker jiuker commented May 6, 2024

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

fix: Ignore AWSAccessKeyId check for SignV2 policy condition

Motivation and Context

How to test this PR?

UT should cover this.

Types of changes

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

Copy link
Member

@harshavardhana harshavardhana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test case that covers these usecases..

@jiuker jiuker force-pushed the fix_19652 branch 4 times, most recently from c49d8fb to 18e9e45 Compare May 6, 2024 06:18
cmd/post-policy_test.go Outdated Show resolved Hide resolved
Ignore AWSAccessKeyId check for SignV2
Copy link
Contributor

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@harshavardhana harshavardhana merged commit 9a9a49a into minio:master May 6, 2024
20 checks passed
@jiuker jiuker deleted the fix_19652 branch May 28, 2024 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants