Make WalkDir return errors #19677
Merged
Make WalkDir return errors #19677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'opts.Marker` is causing many missed entries if used since results are returned unsorted. Also since pools are serialized. Switch to do fully concurrent listing and merging across pools to return sorted entries. Returning errors on listings is impossible with the current API, so document that. Return an error at once if no drives are found instead of just returning an empty listing and no error.
# Conflicts: # cmd/erasure-server-pool.go
harshavardhana
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds errors to WalkDir responses. This means that batch jobs now has an idea of whether they have failed prematurely. This is because if WalkDir terminates it could only close the channel, so it was impossible to detect if there were no more entries or an error occured.
I tried to adapt retry mechanisms reasonably - meaning what I could do without a bigger rewrite.
We now stop updating
RetryAttemptssince some of them were racy. Instead we add "Attempts" which counts total attempts.We also stop counting failed retries as multiple errors. And if a retry succeeds it will deduct from the failures.
Please review carefully as I am not too deep into these systems.
How to test this PR?
Batch jobs with unstable network I guess.
Types of changes