Two way streams fixes - take 2 #19796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ae14681.
Calling `disconnect with locked `respmu` would cause a deadlock, since it calls `close` - which also attempts to get the lock. Also fixes leak in `handleInbound` with a canceled server.
harshavardhana
approved these changes
May 28, 2024
harshavardhana
requested changes
Jun 6, 2024
krisis
approved these changes
Jun 6, 2024
|
@krisis Locking is most obvious. That way the request will track the lifetime of the lock request to the remote. |
harshavardhana
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Re-add #19763 - fixes are individual commits.
Fixes races observed with new tests and tweak tests for flaky operations.
Also fixes a goroutine leak with (unused) two-way streams.
Motivation and Context
How to test this PR?
In internal/grid, use
go test -v --count=100 -race -timeout=30m -failfastor similar.Types of changes