-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
heal: Dangling check to evaluate object parts separately #19797
heal: Dangling check to evaluate object parts separately #19797
Conversation
@harshavardhana @klauspost can you please take a look at this ? there is a lot of tests that need to be fixed and I prefer if I do that after we agree about the changes here |
The approach itself is fine @vadmeste |
Since this change will take time, I will add the commit that would take out dataErrs completely for now. |
avoid this until a comprehensive change is merged such as #19797
e365223
to
637c568
Compare
cc36e2e
to
8692a80
Compare
8692a80
to
3302d1b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. When you are ready, I can do the detailed review.
3302d1b
to
77d9679
Compare
I did it for him 🍰 |
yes, tests are passing now, PTAL @klauspost |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Awesome work!
yeah big time, such an old historic issue. |
Community Contribution License
All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.
Description
Motivation and Context
How to test this PR?
Types of changes
Checklist:
commit-id
orPR #
here)