Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build/release: Generate sha256sums for built binaries. #4311

Merged
merged 1 commit into from May 10, 2017

Conversation

harshavardhana
Copy link
Member

@harshavardhana harshavardhana commented May 10, 2017

Description

Generate sha256sums for built binaries. We used to build sha1sum deprecate it and use sha256sum instead.

Motivation and Context

Fixes #4306

How Has This Been Tested?

Manually using make release

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-io
Copy link

codecov-io commented May 10, 2017

Codecov Report

Merging #4311 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4311      +/-   ##
==========================================
+ Coverage   66.61%   66.63%   +0.02%     
==========================================
  Files         176      176              
  Lines       25071    25071              
==========================================
+ Hits        16700    16707       +7     
+ Misses       7246     7238       -8     
- Partials     1125     1126       +1
Impacted Files Coverage Δ
cmd/fs-v1-background-append.go 78.52% <0%> (-2.69%) ⬇️
cmd/posix.go 73.25% <0%> (-0.16%) ⬇️
cmd/update-notifier.go 75% <0%> (+21.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa3f6d7...93087b2. Read the comment docs.

@nitisht
Copy link
Contributor

nitisht commented May 10, 2017

make release fails on macOS with

If you want to build for all, Just press Enter: linux/386
-->      linux/386:github.com/minio/minio
./buildscripts/build.sh: line 95: release/linux-386/minio.RELEASE.2017-05-10T03-27-55Z: cannot execute binary file

We used to build sha1sum deprecate it and
use sha256sum instead.

Fixes minio#4306
@harshavardhana
Copy link
Member Author

./buildscripts/build.sh: line 95: release/linux-386/minio.RELEASE.2017-05-10T03-27-55Z: cannot execute binary file

Should work fine now.. used a more inter-operable tool.

@nitisht
Copy link
Contributor

nitisht commented May 10, 2017

Should work fine now.. used a more inter-operable tool.

Works

@harshavardhana harshavardhana merged commit fa3d5d0 into minio:master May 10, 2017
@harshavardhana harshavardhana deleted the generated branch May 10, 2017 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide per release download URLs and SHA256 sums
4 participants