Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documenation to reflect correct default region of '' #5101

Merged
merged 1 commit into from Oct 23, 2017

Conversation

kula
Copy link
Contributor

@kula kula commented Oct 23, 2017

Ever since commit 5db1e9f the default region as been '', instead of 'us-east-1'. Update documentation to reflect this, in particular, documentation about notifications.

Description

Two documents were updated to reflect the current default for the region setting.

Motivation and Context

If you try to follow the documentation to set up notifications, you'll be prompted to install event arns with a region set to us-east-1, which will cause event notifications to silently not work, as minio believes it is in the `` region.

How Has This Been Tested?

No testing, documentation changes only.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Ever since commit 5db1e9f the
default region as been '', instead of 'us-east-1'. Update
documentation to reflect this, in particular, documentation about
notifications.
@codecov
Copy link

codecov bot commented Oct 23, 2017

Codecov Report

Merging #5101 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5101      +/-   ##
==========================================
+ Coverage   61.24%   61.24%   +<.01%     
==========================================
  Files         193      193              
  Lines       28411    28411              
==========================================
+ Hits        17399    17400       +1     
- Misses       9747     9748       +1     
+ Partials     1265     1263       -2
Impacted Files Coverage Δ
cmd/fs-v1-background-append.go 73.82% <0%> (-2.69%) ⬇️
cmd/fs-v1-rwpool.go 68.69% <0%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d8a8c6...f009656. Read the comment docs.

@harshavardhana
Copy link
Member

Thanks for the PR but this might be a bug.. when region is not set all regions should be honored..

@deekoder deekoder requested review from deekoder, nitisht and harshavardhana and removed request for nitisht October 23, 2017 16:58
Copy link
Contributor

@deekoder deekoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found that this issue also happened in sqs arn. I had to remove us-east-1. So i approve.

Copy link
Member

@krisis krisis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @kula. This document change reflects the current behaviour. We can take this in and address server behaviour later, if required.

@deekoder
Copy link
Contributor

I will open a separate issue for the server also being ok with us-east-1 in the arn.

@deekoder deekoder merged commit 758d545 into minio:master Oct 23, 2017
harshavardhana added a commit to harshavardhana/minio that referenced this pull request Oct 26, 2017
@harshavardhana
Copy link
Member

us-east-1 ARN seems to be not the problem here

mc events add myminio/testbucket arn:minio:sqs:us-east-1:test1:redis
Successfully added arn:minio:sqs:us-east-1:test1:redis

This is successful even with server region being empty, i see that we already have code to handle this correctly. But there is a problem when sending events though.

While it is saved as is the notification is picked from a map which doesn't store it in the same manner, this is a bug. Doc fix is correct but the correct fix is .. #5119

harshavardhana added a commit to harshavardhana/minio that referenced this pull request Oct 26, 2017
harshavardhana added a commit to harshavardhana/minio that referenced this pull request Oct 26, 2017
harshavardhana added a commit to harshavardhana/minio that referenced this pull request Oct 27, 2017
harshavardhana added a commit to harshavardhana/minio that referenced this pull request Oct 27, 2017
deekoder pushed a commit that referenced this pull request Oct 27, 2017
dvstate pushed a commit to dvstate/minio that referenced this pull request Nov 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants