New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documenation to reflect correct default region of '' #5101
Conversation
Ever since commit 5db1e9f the default region as been '', instead of 'us-east-1'. Update documentation to reflect this, in particular, documentation about notifications.
Codecov Report
@@ Coverage Diff @@
## master #5101 +/- ##
==========================================
+ Coverage 61.24% 61.24% +<.01%
==========================================
Files 193 193
Lines 28411 28411
==========================================
+ Hits 17399 17400 +1
- Misses 9747 9748 +1
+ Partials 1265 1263 -2
Continue to review full report at Codecov.
|
Thanks for the PR but this might be a bug.. when region is not set all regions should be honored.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found that this issue also happened in sqs arn. I had to remove us-east-1. So i approve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @kula. This document change reflects the current behaviour. We can take this in and address server behaviour later, if required.
I will open a separate issue for the server also being ok with us-east-1 in the arn. |
us-east-1 ARN seems to be not the problem here
This is successful even with server region being empty, i see that we already have code to handle this correctly. But there is a problem when sending events though. While it is saved as is the notification is picked from a map which doesn't store it in the same manner, this is a bug. Doc fix is correct but the correct fix is .. #5119 |
Ever since commit 5db1e9f the default region as been '', instead of 'us-east-1'. Update documentation to reflect this, in particular, documentation about notifications.
Description
Two documents were updated to reflect the current default for the
region
setting.Motivation and Context
If you try to follow the documentation to set up notifications, you'll be prompted to install event arns with a region set to
us-east-1
, which will cause event notifications to silently not work, asminio
believes it is in the `` region.How Has This Been Tested?
No testing, documentation changes only.
Types of changes
Checklist: