Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused value from retry-storage #5129

Merged
merged 1 commit into from Oct 29, 2017
Merged

Conversation

harshavardhana
Copy link
Member

@harshavardhana harshavardhana commented Oct 28, 2017

Description

Remove unused value from retry-storage

Motivation and Context

Unused value from code base

How Has This Been Tested?

Manually using make test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Oct 28, 2017

Codecov Report

Merging #5129 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5129   +/-   ##
=======================================
  Coverage   61.59%   61.59%           
=======================================
  Files         194      194           
  Lines       28694    28694           
=======================================
  Hits        17674    17674           
  Misses       9752     9752           
  Partials     1268     1268
Impacted Files Coverage Δ
cmd/retry-storage.go 67.37% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 203ac8e...329b27d. Read the comment docs.

Copy link
Contributor

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nitisht nitisht merged commit 8d584bd into minio:master Oct 29, 2017
@harshavardhana harshavardhana deleted the fix-init branch October 29, 2017 18:04
dvstate pushed a commit to dvstate/minio that referenced this pull request Nov 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants