Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gateway/azure: Return an empty list if no chunks uploaded yet #5230

Merged
merged 1 commit into from Nov 28, 2017

Conversation

pauln
Copy link
Contributor

@pauln pauln commented Nov 24, 2017

This makes ListParts behave more like S3 by returning an empty list rather than an error if no chunks/blocks have been uploaded yet.

This is a replacement for #5226, suggested by @krishnasrinivas in the comments on that PR.

Description

See #5226 for more background on and discussion about this fix.

Motivation and Context

As discussed in #5169, this is required for tus/tusd to be able to use Minio Azure Gateway.

How Has This Been Tested?

Tested manually, using tusd to send a repeatable and realistic set of calls which work as expected on S3 but don't currently work on Minio Azure Gateway.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added unit tests to cover my changes.
  • I have added/updated functional tests in mint. (If yes, add mint PR # here: )
  • All new and existing tests passed.

This makes ListParts behave more like S3 by returning an empty list rather than an error if no chunks/blocks have been uploaded yet.
@codecov
Copy link

codecov bot commented Nov 24, 2017

Codecov Report

Merging #5230 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5230      +/-   ##
==========================================
+ Coverage   60.22%   60.22%   +<.01%     
==========================================
  Files         194      194              
  Lines       29472    29477       +5     
==========================================
+ Hits        17749    17753       +4     
- Misses      10392    10393       +1     
  Partials     1331     1331
Impacted Files Coverage Δ
cmd/gateway-azure.go 21.31% <0%> (-0.16%) ⬇️
cmd/fs-v1-rwpool.go 60.86% <0%> (-4.35%) ⬇️
cmd/fs-v1-background-append.go 81.2% <0%> (+4.69%) ⬆️
cmd/xl-v1-common.go 100% <0%> (+5.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08e0698...5eede6d. Read the comment docs.

@harshavardhana harshavardhana changed the title Azure Gateway: Return an empty list if no chunks uploaded yet gateway/azure: Return an empty list if no chunks uploaded yet Nov 24, 2017
Copy link
Member

@harshavardhana harshavardhana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM tested.

@harshavardhana harshavardhana merged commit 6a2d7ae into minio:master Nov 28, 2017
@pauln pauln deleted the azure-empty-listparts branch November 28, 2017 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants