New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[proposal] Support creating directories on erasure coded backend #5306

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@harshavardhana
Copy link
Member

harshavardhana commented Dec 18, 2017

Description

Support creating directories on erasure coded backend

Motivation and Context

This PR continues from #5049 where we started supporting
directories for filesystem backend.

How Has This Been Tested?

Manually using awscli tests on mint for the same feature on FS backend.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added unit tests to cover my changes.
  • I have added/updated functional tests in mint. (If yes, add mint PR # here: )
  • All new and existing tests passed.

@nitisht nitisht requested review from krisis and balamurugana Dec 18, 2017

@harshavardhana

This comment has been minimized.

Copy link
Member

harshavardhana commented Dec 18, 2017

To test please use the commit before a recent merge to remove the awscli test to test directory creates. https://github.com/minio/mint/commits/master

docker run --net=host -e SERVER_ENDPOINT=127.0.0.1:9000 -e ACCESS_KEY=minio -e SECRET_KEY=minio123 -e ENABLE_HTTPS=0 -e MINT_MODE=full minio/mint:edge awscli
Running with
SERVER_ENDPOINT: 127.0.0.1:9000
ACCESS_KEY:      minio
SECRET_KEY:      ***REDACTED***
ENABLE_HTTPS:    0
SERVER_REGION:   us-east-1
MINT_DATA_DIR:   /mint/data
MINT_MODE:       full

To get logs, run 'sudo docker cp ecaa38ce02e7:/mint/log /tmp/mint-logs'
(1/1) Running awscli tests ... done in 40 seconds

All tests ran successfully

@harshavardhana harshavardhana force-pushed the harshavardhana:proposal-directories branch 3 times, most recently from 3a22096 to d592820 Dec 18, 2017

@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 22, 2017

Codecov Report

Merging #5306 into master will increase coverage by 3.56%.
The diff coverage is 75.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5306      +/-   ##
==========================================
+ Coverage    62.4%   65.97%   +3.56%     
==========================================
  Files         201      144      -57     
  Lines       31114    24087    -7027     
==========================================
- Hits        19418    15892    -3526     
+ Misses      10256     6945    -3311     
+ Partials     1440     1250     -190
Impacted Files Coverage Δ
cmd/object-api-input-checks.go 94.94% <100%> (ø) ⬆️
cmd/fs-v1.go 76.13% <100%> (-2.37%) ⬇️
cmd/xl-v1-object.go 77.25% <71.42%> (-1.84%) ⬇️
cmd/posix.go 70.99% <88.88%> (-3.1%) ⬇️
cmd/storage-rpc-client.go 36.63% <0%> (-38.12%) ⬇️
cmd/update-notifier.go 58.33% <0%> (-23.34%) ⬇️
cmd/storage-rpc-server.go 52.63% <0%> (-23.31%) ⬇️
cmd/posix-errors.go 51.66% <0%> (-16.67%) ⬇️
cmd/xl-v1-healing.go 70.83% <0%> (-15.21%) ⬇️
cmd/namespace-lock.go 65.36% <0%> (-13.66%) ⬇️
... and 109 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c072116...19097b1. Read the comment docs.

@harshavardhana harshavardhana force-pushed the harshavardhana:proposal-directories branch from d592820 to 4e2e805 Dec 22, 2017

@harshavardhana

This comment has been minimized.

Copy link
Member

harshavardhana commented Dec 22, 2017

this is blocked on @abperiasamy // cc @nitisht

@harshavardhana harshavardhana force-pushed the harshavardhana:proposal-directories branch 2 times, most recently from 77624f7 to 3a352a1 Dec 23, 2017

@nitisht nitisht added the blocked label Dec 28, 2017

@harshavardhana harshavardhana force-pushed the harshavardhana:proposal-directories branch from 3a352a1 to 117161c Dec 31, 2017

[proposal] Support creating directories on erasure coded backend
This PR continues from #5049 where we started supporting
directories for erasure coded backend

@harshavardhana harshavardhana force-pushed the harshavardhana:proposal-directories branch from 117161c to 19097b1 Jan 4, 2018

@harshavardhana harshavardhana deleted the harshavardhana:proposal-directories branch Jan 4, 2018

@harshavardhana

This comment has been minimized.

Copy link
Member

harshavardhana commented Jan 4, 2018

Closing PR and re-opening again.

@harshavardhana harshavardhana restored the harshavardhana:proposal-directories branch Jan 4, 2018

@balamurugana

This comment has been minimized.

Copy link
Member

balamurugana commented Jan 4, 2018

mint-xl.sh: PASSED
---
mint-fs.sh: PASSED
---
mint-dist-xl.sh: PASSED
---

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment