New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add chroot environment doc for minio #5366
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## master #5366 +/- ##
=========================================
- Coverage 61.11% 61.1% -0.02%
=========================================
Files 201 201
Lines 29520 29520
=========================================
- Hits 18042 18039 -3
- Misses 10087 10091 +4
+ Partials 1391 1390 -1
Continue to review full report at Codecov.
|
docs/chroot/README.md
Outdated
|
||
## 2. Install Minio in Chroot | ||
```sh | ||
mkdir /mnt/export/${USER}/bin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably mkdir -p /mnt/export/${USER}/bin
is better as I dont see /mnt/export
directory by default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure.
docs/chroot/README.md
Outdated
## 2. Install Minio in Chroot | ||
```sh | ||
mkdir /mnt/export/${USER}/bin | ||
wget https://dl.minio.io/server/minio/release/linux-amd64/minio -O /mnt/export/${USER}/bin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wget https://dl.minio.io/server/minio/release/linux-amd64/minio -O /mnt/export/${USER}/bin/minio
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure
docs/chroot/README.md
Outdated
mkdir /mnt/export/${USER}/bin | ||
wget https://dl.minio.io/server/minio/release/linux-amd64/minio -O /mnt/export/${USER}/bin | ||
chmod +x /mnt/export/${USER}/bin/minio | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably $cd /mnt/export/${USER}/bin
should be added here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why cd ?
|
38e8b95
to
679b9f0
Compare
@nitisht PTAL addressed your comments.. @donatello ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
679b9f0
to
7f3520c
Compare
docs/chroot/README.md
Outdated
### GNU/Linux | ||
```sh | ||
chroot --userspec ${USER}:{USER} /mnt/export/${USER} /bin/minio --config-dir=/.minio server /data | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should specify that this command would need to be executed by root.
Also s/${USER}:{USER}/${USER}:${USER}
. Alternatively we should specify that after :
the group name can be given.
Finally, when I tried it, I couldn't get it to work:
$ find /tmp/chroot/
/tmp/chroot/
/tmp/chroot/bin
/tmp/chroot/bin/minio
/tmp/chroot/ls
$ sudo chroot --userspec aditya:aditya /tmp/chroot/ /bin/minio --config-dir=/.minio server /data
FATA[0000] Invalid command line arguments server=‘:9000’, args=[/data] cause=open /proc/mounts: no such file or directory source=[server-main.go:96:serverHandleCmdArgs()]
7f3520c
to
5247783
Compare
Mint Automation
5366-5247783/mint-xl.sh.log:
5366-5247783/mint-gateway-azure.sh.log:
5366-5247783/mint-dist-xl.sh.log:
5366-5247783/mint-fs.sh.log:
5366-5247783/mint-gateway-s3.sh.log:
|
Description
Add chroot environment doc for minio
Motivation and Context
Fixes #4659
How Has This Been Tested?
Following the doc
Types of changes
Checklist:
mint
PR # here: )