Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove upload healing related dead code #5404

Merged
merged 1 commit into from Jan 16, 2018

Conversation

donatello
Copy link
Member

Description

Some dead code related to upload healing removed in #5390 is being removed in this PR.

How Has This Been Tested?

Tests pass.

@codecov
Copy link

codecov bot commented Jan 15, 2018

Codecov Report

Merging #5404 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5404      +/-   ##
==========================================
- Coverage   61.52%   61.51%   -0.02%     
==========================================
  Files         202      202              
  Lines       29387    29214     -173     
==========================================
- Hits        18081    17970     -111     
+ Misses       9906     9858      -48     
+ Partials     1400     1386      -14
Impacted Files Coverage Δ
cmd/gateway-unsupported.go 0% <ø> (ø) ⬆️
cmd/fs-v1.go 72.61% <ø> (+0.2%) ⬆️
cmd/xl-v1-list-objects-heal.go 81.59% <ø> (+10.51%) ⬆️
cmd/notify-webhook.go 74.63% <0%> (-0.73%) ⬇️
cmd/xl-v1-multipart.go 70.25% <0%> (-0.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78a641f...b22f8ce. Read the comment docs.

@balamurugana
Copy link
Member

Mint Automation

Test Result
mint-xl.sh ✔️
mint-fs.sh ✔️
mint-dist-xl.sh ✔️
mint-gateway-azure.sh ✔️
mint-gateway-s3.sh more...

5404-b22f8ce/mint-gateway-s3.sh.log:

Running with
SERVER_ENDPOINT: minikube:32571
ACCESS_KEY:      AKIAJH7GQKYNU3C2ADXA
SECRET_KEY:      ***REDACTED***
ENABLE_HTTPS:    0
SERVER_REGION:   us-east-1
MINT_DATA_DIR:   /mint/data
MINT_MODE:       core

To get logs, run 'docker cp f185e4450c99:/mint/log /tmp/mint-logs'
(1/11) Running aws-sdk-go tests ... done in 2 seconds
(2/11) Running aws-sdk-php tests ... done in 1 minutes and 19 seconds
(3/11) Running aws-sdk-ruby tests ... done in 1 minutes and 25 seconds
(4/11) Running awscli tests ... done in 9 minutes and 28 seconds
(5/11) Running mc tests ... done in 5 minutes and 8 seconds
(6/11) Running minio-dotnet tests ... done in 1 minutes and 27 seconds
(7/11) Running minio-go tests ... done in 22 seconds
(8/11) Running minio-java tests ... FAILED in 48 seconds
{
  "name": "minio-java",
  "function": "setBucketPolicy(String bucketName, String objectPrefix, PolicyType policyType)",
  "duration": 4659,
  "status": "FAIL",
  "error": "error occured\nErrorResponse(code=AccessDenied, message=Access Denied., bucketName=null, objectName=null, resource=/minio-java-test-1fhjlm4/set-bucket-policy-read-write/minio-java-test-35d9dk, requestId=3L137, hostId=3L137)\nrequest={method=GET, url=http://minikube:32571/minio-java-test-1fhjlm4/set-bucket-policy-read-write/minio-java-test-35d9dk, headers=Host: minikube:32571\nUser-Agent: Minio (amd64; amd64) minio-java/dev\nx-amz-content-sha256: e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855\nx-amz-date: 20180115T192324Z\nAuthorization: AWS4-HMAC-SHA256 Credential=*REDACTED*/20180115/us-east-1/s3/aws4_request, SignedHeaders=host;x-amz-content-sha256;x-amz-date, Signature=*REDACTED*\n}\nresponse={code=403, headers=Accept-Ranges: bytes\nContent-Type: application/xml\nServer: Minio/DEVELOPMENT.2018-01-15T19-00-08Z (linux; amd64)\nVary: Origin\nX-Amz-Request-Id: 150A122BEAA10EBF\nDate: Mon, 15 Jan 2018 19:23:24 GMT\nTransfer-Encoding: chunked\n}\n >>> [io.minio.MinioClient.execute(MinioClient.java:1201), io.minio.MinioClient.executeGet(MinioClient.java:1294), io.minio.MinioClient.getObject(MinioClient.java:1594), io.minio.MinioClient.getObject(MinioClient.java:1506), FunctionalTest.testSetBucketPolicy(FunctionalTest.java:2291), FunctionalTest.setBucketPolicy_test4(FunctionalTest.java:2346), FunctionalTest.runQuickTests(FunctionalTest.java:2649), FunctionalTest.main(FunctionalTest.java:2691)]"
}

Executed 7 out of 11 tests successfully.

Copy link
Member

@harshavardhana harshavardhana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kannappanr kannappanr merged commit aa7e5c7 into minio:master Jan 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants