Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing env doc for MINIO_DOMAIN #5705

Merged
merged 1 commit into from Mar 26, 2018

Conversation

harshavardhana
Copy link
Member

@harshavardhana harshavardhana commented Mar 25, 2018

Description

Add missing env doc for MINIO_DOMAIN

Motivation and Context

fixing docs

How Has This Been Tested?

visually

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added unit tests to cover my changes.
  • I have added/updated functional tests in mint. (If yes, add mint PR # here: )
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Mar 25, 2018

Codecov Report

Merging #5705 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5705      +/-   ##
==========================================
+ Coverage   62.19%   62.19%   +<.01%     
==========================================
  Files         192      192              
  Lines       27388    27402      +14     
==========================================
+ Hits        17034    17043       +9     
- Misses       8979     8981       +2     
- Partials     1375     1378       +3
Impacted Files Coverage Δ
cmd/server-main.go 12.66% <ø> (ø) ⬆️
cmd/gateway/azure/gateway-azure.go 27.58% <100%> (+0.25%) ⬆️
cmd/gateway/oss/gateway-oss.go 20.93% <100%> (+0.56%) ⬆️
cmd/gateway/sia/gateway-sia.go 11.52% <100%> (+0.6%) ⬆️
cmd/gateway/s3/gateway-s3.go 19.28% <100%> (+0.82%) ⬆️
cmd/gateway/b2/gateway-b2.go 18.18% <100%> (+0.4%) ⬆️
cmd/gateway/gcs/gateway-gcs.go 23.66% <100%> (+0.26%) ⬆️
cmd/xl-v1-common.go 94.87% <0%> (-5.13%) ⬇️
cmd/fs-v1-rwpool.go 64.34% <0%> (-2.61%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c747a9...eeb58da. Read the comment docs.

balamurugana
balamurugana previously approved these changes Mar 26, 2018
Copy link
Member

@balamurugana balamurugana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@nitisht nitisht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO we can change To enable virtual-host-style requests. By default only path-style requests are allowed. to To enable virtual-host-style requests, set this value to Minio host's domain name.

This will be clearer for users on what should be set in this variable.

@harshavardhana
Copy link
Member Author

IMHO we can change To enable virtual-host-style requests. By default only path-style requests are allowed. to To enable virtual-host-style requests, set this value to Minio host's domain name.

This will be clearer for users on what should be set in this variable.

done @nitisht

Copy link
Contributor

@nitisht nitisht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@balamurugana
Copy link
Member

Mint Automation

Test Result
mint-xl.sh ✔️
mint-fs.sh ✔️
mint-dist-xl.sh ✔️
mint-gateway-s3.sh ✔️
mint-gateway-azure.sh ✔️

Copy link
Member

@balamurugana balamurugana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kannappanr kannappanr merged commit 35e6457 into minio:master Mar 26, 2018
@harshavardhana harshavardhana deleted the fix-domain branch March 26, 2018 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants