New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing env doc for MINIO_DOMAIN #5705
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5705 +/- ##
==========================================
+ Coverage 62.19% 62.19% +<.01%
==========================================
Files 192 192
Lines 27388 27402 +14
==========================================
+ Hits 17034 17043 +9
- Misses 8979 8981 +2
- Partials 1375 1378 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO we can change To enable virtual-host-style requests. By default only path-style requests are allowed.
to To enable virtual-host-style requests, set this value to Minio host's domain name.
This will be clearer for users on what should be set in this variable.
9e9f163
to
eeb58da
Compare
done @nitisht |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Mint Automation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Add missing env doc for MINIO_DOMAIN
Motivation and Context
fixing docs
How Has This Been Tested?
visually
Types of changes
Checklist:
mint
PR # here: )