The mc admin info command should be working irrespective to the regions #5919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Praveenrajmani this is not the only place which needs fixing, it is completely okay to have the check for region. In-fact pkg/madmin should be able to support different regions. Will need to discuss this with @abperiasamy on how to achieve this specifically for Admin API. There are two options
|
Praveenrajmani
force-pushed
the
adminInfoRegionFix
branch
from
9df7ce4
to
000d18c
Compare
Codecov Report
@@ Coverage Diff @@
## master #5919 +/- ##
==========================================
- Coverage 59.65% 59.64% -0.02%
==========================================
Files 217 217
Lines 30939 30941 +2
==========================================
- Hits 18458 18455 -3
- Misses 10933 10938 +5
Partials 1548 1548
Continue to review full report at Codecov.
|
harshavardhana
requested changes
May 27, 2018
Praveenrajmani
force-pushed
the
adminInfoRegionFix
branch
2 times, most recently
from
dcb4c6d
to
b9a36dc
Compare
|
@harshavardhana the changes are Done |
harshavardhana
requested changes
May 30, 2018
There was a problem hiding this comment.
Everything looks good. Commit message can be a bit more concise. We don't have to write Cause and Solution in separate paragraphs. We don't follow such type of patterns. Also make sure that the commit message and the respective description each line shouldn't go beyond perhaps 100 to 120 characters.
Praveenrajmani
force-pushed
the
adminInfoRegionFix
branch
from
b9a36dc
to
e7a0b2c
Compare
|
yes @harshavardhana got it ! have changed it |
harshavardhana
previously approved these changes
Jun 1, 2018
Admin API is not an S3 API and hence it is not required to honor server region while validating admin API calls. Fixes minio#2411
Praveenrajmani
force-pushed
the
adminInfoRegionFix
branch
from
e7a0b2c
to
2b9a322
Compare
|
@harshavardhana @balamurugana have modified the git commit message |
harshavardhana
approved these changes
Jun 2, 2018
Mint Automation
5919-2b9a322/mint-dist-xl.sh.log:5919-2b9a322/mint-gateway-s3.sh.log: |
balamurugana
approved these changes
Jun 7, 2018
Praveenrajmani
added a commit
to Praveenrajmani/minio
that referenced
this pull request
Jun 25, 2018
Admin API is not an S3 API and hence it is not required to honor server region while validating admin API calls. Fixes minio#2411
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The mc admin info command was throwing signature mismatch in #5918 , as the server validates the request signature with the globalServerConfig.Region,
So, if the region in config.json is set to some other except 'us-east-1' ,
the signature mismatch happens, as the mc admin info always signs with 'us-east-1' as per the spec.
Motivation and Context
The mc admin info was throwing signature mismatch for any other region in config.json except
'us-east-1'
solves: #5918
Types of changes
Checklist:
mintPR # here: )