Remove redundant prometheus data points #5934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed field minio_http_requests_total as it was redundant with minio_http_requests_duration_seconds_count Also removed field minio_server_start_time_seconds as it was redundant with process_start_time_seconds
Codecov Report
@@ Coverage Diff @@
## master #5934 +/- ##
=========================================
+ Coverage 59.57% 59.6% +0.03%
=========================================
Files 214 214
Lines 30786 30772 -14
=========================================
+ Hits 18342 18343 +1
+ Misses 10899 10881 -18
- Partials 1545 1548 +3
Continue to review full report at Codecov.
|
vadmeste
reviewed
May 15, 2018
| @@ -190,8 +190,6 @@ func (st *HTTPStats) updateStats(r *http.Request, w *httpResponseRecorder, durat | |||
| st.successDELETEs.Duration.Add(durationSecs) | |||
| } | |||
| } | |||
| // Increment the prometheus http request count with appropriate label | |||
| httpRequests.With(prometheus.Labels{"request_type": r.Method}).Inc() | |||
There was a problem hiding this comment.
@nitisht I am not sure how number of requests count is redundant with requests duration, can you elaborate ?
There was a problem hiding this comment.
harshavardhana
approved these changes
May 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed field minio_http_requests_total as it was redundant with
minio_http_requests_duration_seconds_count
Also removed field minio_server_start_time_seconds as it was
redundant with process_start_time_seconds
Motivation and Context
This PR removes couple of redundant fields in Prometheus data exported by Minio server.
How Has This Been Tested?
Manually
Types of changes
Checklist:
mintPR # here: )