Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate showing drive capacity and total free #5976

Merged
merged 1 commit into from May 24, 2018

Conversation

harshavardhana
Copy link
Member

@harshavardhana harshavardhana commented May 23, 2018

Description

Deprecate showing drive capacity and total free

Motivation and Context

This addresses a situation that we shouldn't be
displaying Total/Free anyone instead we should simply
show the total usage.

How Has This Been Tested?

Manually

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added unit tests to cover my changes.
  • I have added/updated functional tests in mint. (If yes, add mint PR # here: )
  • All new and existing tests passed.

Copy link
Contributor

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This addresses a situation that we shouldn't be
displaying Total/Free anyone instead we should simply
show the total usage.
@codecov
Copy link

codecov bot commented May 24, 2018

Codecov Report

Merging #5976 into master will decrease coverage by 0.02%.
The diff coverage is 54.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5976      +/-   ##
==========================================
- Coverage   59.66%   59.63%   -0.03%     
==========================================
  Files         215      215              
  Lines       30888    30868      -20     
==========================================
- Hits        18428    18408      -20     
+ Misses      10917    10916       -1     
- Partials     1543     1544       +1
Impacted Files Coverage Δ
cmd/xl-sets.go 58.56% <ø> (-0.09%) ⬇️
pkg/madmin/info-commands.go 0% <ø> (ø) ⬆️
cmd/xl-v1.go 85.84% <100%> (-0.72%) ⬇️
cmd/server-startup-msg.go 80.45% <40%> (-2.26%) ⬇️
cmd/posix.go 72.1% <50%> (+0.06%) ⬆️
cmd/fs-v1.go 66.95% <53.84%> (-0.49%) ⬇️
cmd/fs-v1-helpers.go 69.81% <0%> (+0.91%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6ec645...092474d. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants