New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redirect browser requests only if the browser is enabled #6909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes an issue introduced in PR minio#6848, when browser is disabled we shouldn't re-direct the requests returning AccessDenied. Fixes minio#6907
Mint Automation
6909-4bccf93/mint-dist-xl.sh.log:
|
Codecov Report
@@ Coverage Diff @@
## master #6909 +/- ##
==========================================
+ Coverage 51.98% 52.24% +0.26%
==========================================
Files 260 270 +10
Lines 32535 42610 +10075
==========================================
+ Hits 16912 22261 +5349
- Misses 13657 18385 +4728
+ Partials 1966 1964 -2
Continue to review full report at Codecov.
|
poornas
approved these changes
Dec 2, 2018
ping @balamurugana |
balamurugana
approved these changes
Dec 4, 2018
richardkiene
pushed a commit
to richardkiene/minio
that referenced
this pull request
Jan 2, 2019
This PR fixes an issue introduced in PR minio#6848, when browser is disabled we shouldn't re-direct the requests returning AccessDenied. Fixes minio#6907
richardkiene
pushed a commit
to richardkiene/minio
that referenced
this pull request
Jan 2, 2019
This PR fixes an issue introduced in PR minio#6848, when browser is disabled we shouldn't re-direct the requests returning AccessDenied. Fixes minio#6907
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Redirect browser requests only if the browser is enabled
Motivation and Context
This PR fixes an issue introduced in PR #6848, when
the browser is disabled we shouldn't re-direct the requests
returning AccessDenied.
Fixes #6907
Regression
yes introduced in #6848
How Has This Been Tested?
Accessing Minio URL from the browser when the browser is disabled.
Types of changes
Checklist:
mint
PR # here: )