Healing process should not heal root disk #7089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
approved these changes
Jan 16, 2019
Mint Automation
|
harshavardhana
requested changes
Jan 16, 2019
cmd/posix.go
Outdated
| if diskStat.Dev == rootStat.Dev { | ||
| // Indicate if the disk path is on root disk. This is used to indicate the healing | ||
| // process not to format the drive and end up healing it. | ||
| IsRootDisk = true |
There was a problem hiding this comment.
Can be simplied to IsRootDisk = diskStat.Dev == rootStat.Dev , also variable name can be just rootDisk which has true/false
I like the idea to determine this during Heal instead of newPosix() avoids state and false positives.
There was a problem hiding this comment.
@krishnasrinivas can you take a look
Codecov Report
@@ Coverage Diff @@
## master #7089 +/- ##
==========================================
+ Coverage 51.19% 51.42% +0.23%
==========================================
Files 267 279 +12
Lines 33667 43976 +10309
==========================================
+ Hits 17236 22616 +5380
- Misses 14344 19273 +4929
Partials 2087 2087
Continue to review full report at Codecov.
|
|
@krishnasrinivas you need to fix windows build issues https://travis-ci.org/minio/minio/jobs/481015811 |
krishnasrinivas
force-pushed
the
dont-heal-root-disk
branch
from
bd3dc32
to
fdd7b1b
Compare
harshavardhana
approved these changes
Jan 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If an admin umounts a disk and runs heal, currently we endup healing a directory on the root FS. This PR ensures that when we heal, format healing is done only on non-root disks.
Motivation and Context
If we heal a directory on root disk we will end up filling up the root disk
Regression
No
How Has This Been Tested?
By using a loop mounted FS, I was able to simulate actualy disk mount to test this.
mintPR # here: )