Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DummyHandlers to authorize and send/validate correct XMLs #7223

Merged
merged 1 commit into from
Feb 12, 2019

Conversation

harshavardhana
Copy link
Member

@harshavardhana harshavardhana commented Feb 11, 2019

Description

Fix DummyHandlers to authorize and send/validate correct XMLs

Motivation and Context

Fix incorrectly implemented handlers

Regression

No

How Has This Been Tested?

Using AWS SDKs

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added unit tests to cover my changes.
  • I have added/updated functional tests in mint. (If yes, add mint PR # here: )
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Feb 11, 2019

Codecov Report

Merging #7223 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7223      +/-   ##
==========================================
- Coverage    48.8%   48.78%   -0.03%     
==========================================
  Files         295      295              
  Lines       45512    45515       +3     
==========================================
- Hits        22214    22203      -11     
- Misses      21274    21284      +10     
- Partials     2024     2028       +4
Impacted Files Coverage Δ
cmd/dummy-handlers.go 0% <0%> (ø) ⬆️
cmd/posix.go 64.52% <0%> (-1.18%) ⬇️
cmd/fs-v1-helpers.go 68.19% <0%> (-0.62%) ⬇️
cmd/posix-list-dir_windows.go 60.29% <0%> (+1.47%) ⬆️
cmd/disk-usage.go 100% <0%> (+5.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13c3b8a...c14ae0f. Read the comment docs.

cmd/dummy-handlers.go Outdated Show resolved Hide resolved
@harshavardhana
Copy link
Member Author

Fixed PTAL @kannappanr @ebozduman

Copy link
Contributor

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ebozduman ebozduman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@minio-ops
Copy link

Mint Automation

Test Result
mint-compression-xl.sh ✔️
mint-xl.sh ✔️
mint-large-bucket.sh ✔️
mint-compression-dist-xl.sh ✔️
mint-compression-fs.sh ✔️
mint-worm.sh ✔️
mint-fs.sh ✔️
mint-dist-xl.sh ✔️
mint-gateway-nas.sh ✔️

@kannappanr kannappanr merged commit b8955fe into minio:master Feb 12, 2019
@harshavardhana harshavardhana deleted the fix-dummy branch February 12, 2019 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants