New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http2 throws custom error Content-Length shorter handle it #7334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
force-pushed
the
http2
branch
2 times, most recently
from
March 7, 2019 00:26
84d6c93
to
886324f
Compare
Codecov Report
@@ Coverage Diff @@
## master #7334 +/- ##
==========================================
+ Coverage 48.42% 48.42% +<.01%
==========================================
Files 296 296
Lines 46394 46408 +14
==========================================
+ Hits 22465 22473 +8
- Misses 21862 21869 +7
+ Partials 2067 2066 -1
Continue to review full report at Codecov.
|
harshavardhana
force-pushed
the
http2
branch
2 times, most recently
from
March 7, 2019 20:00
02c148a
to
4e4721f
Compare
krishnasrinivas
previously approved these changes
Mar 7, 2019
We should internally handle when http2 input stream has smaller content than its content-length header Upstream issue reported golang/go#30648 This a change which we need to handle internally until Go fixes it correctly, till now our code doesn't expect a custom error to be returned.
poornas
approved these changes
Mar 7, 2019
Mint Automation
7334-e86a4f4/mint-dist-xl.sh.log:
7334-e86a4f4/mint-large-bucket.sh.log:
|
krishnasrinivas
approved these changes
Mar 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
http2 throws custom error Content-Length shorter handle it
Motivation and Context
We should internally handle when http2 input stream has smaller
content than its content-length header
Upstream issue reported golang/go#30648
This a change which we need to handle internally until Go fixes it
correctly, till now our code doesn't expect a custom error to be returned.
Regression
In a way
How Has This Been Tested?
Using http2 server and minio-java tests with this PR https://github.com/minio/minio-java/pull/758/files#diff-b434019f6f2c56a278f611c67601eb94R1140 should pass.
Types of changes
Checklist:
mint
PR # here: )