New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more friendly error message for policy object #7412
Conversation
9c416c3
to
820626e
Compare
Codecov Report
@@ Coverage Diff @@
## master #7412 +/- ##
==========================================
+ Coverage 47.4% 47.43% +0.02%
==========================================
Files 294 294
Lines 46740 46740
==========================================
+ Hits 22158 22172 +14
+ Misses 22528 22517 -11
+ Partials 2054 2051 -3
Continue to review full report at Codecov.
|
@lunixoid, trying to understand why you need to give download access on each individual subdirectory prefix when you might want to just give download access on bucket/* which would in essence accomplish the same without policy bloat. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, some review comments..
820626e
to
c7acc2f
Compare
c7acc2f
to
6799b54
Compare
It was my mistake, but in any case current error message don't help to understand the problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you check why CI failed ?
6d7e018
to
0146a9d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Mint Automation
7412-b7e1f5e/mint-fs.sh.log:
7412-b7e1f5e/mint-large-bucket.sh.log:
|
ping @poornas |
In our projects we use minio as the storage sever. Each bucket equals - git project. After building project CI uploads artefact into minio and sets
mc policy download
for subdirectory. Name of subdirectory in bucket depends on name of current brunch (develop, master).So after some time of working our bucket policy file reach limit 20K and send us error:
Your proposed upload exceeds the maximum allowed object size.
We spent a lot of time to understand and resolve this issue, so I suggest to extend error message for this case.